Fix pyproto documentation. #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejrs
commented
Aug 21, 2022
src/lib.rs
Outdated
| @@ -89,6 +87,8 @@ | |||
| //! - `multiple-pymethods`: Enables the use of multiple [`#[pymethods]`](macro@crate::pymethods) | |||
| //! blocks per [`#[pyclass]`](macro@crate::pyclass). This adds a dependency on the [inventory] | |||
| //! crate, which is not supported on all platforms. | |||
| //! - `pyproto`: Enables the deprecated `#[pyproto]` attribute macro. This will be removed in a | |||
| //! future release. | |||
There was a problem hiding this comment.
Do we want to mention a concrete version? 0.18 perhaps?
There was a problem hiding this comment.
I think it's fine to say 0.18 here 👍 (I'm already planning to have a bonfire PR as soon as 0.17 is out the door xD)
davidhewitt
reviewed
Aug 21, 2022
src/lib.rs
Outdated
| @@ -89,6 +87,8 @@ | |||
| //! - `multiple-pymethods`: Enables the use of multiple [`#[pymethods]`](macro@crate::pymethods) | |||
| //! blocks per [`#[pyclass]`](macro@crate::pyclass). This adds a dependency on the [inventory] | |||
| //! crate, which is not supported on all platforms. | |||
| //! - `pyproto`: Enables the deprecated `#[pyproto]` attribute macro. This will be removed in a | |||
| //! future release. | |||
There was a problem hiding this comment.
I think it's fine to say 0.18 here 👍 (I'm already planning to have a bonfire PR as soon as 0.17 is out the door xD)
davidhewitt
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #2322 this is not enabled by default.